Allow to change map colors #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey. Thank you for your PR. IMO this would break config for everyone who simply do a regular update. I assume you would need to implement default colors if not set logic. Would you be able to do it? |
|
Yeah, I can do that.
…On Thu, 8 Feb 2024 at 10:31, Erikas ***@***.***> wrote:
Hey. Thank you for your PR.
IMO this would break config for everyone who simply do a regular update. I
assume you would need to implement *default colors if not set* logic.
Would you be able to do it?
—
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEGBNDNV44NAESGC5PUY4GTYSSLP3AVCNFSM6AAAAABCOHZPH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZTGY3TSMJVGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Cool, I was searching for this feature. |
|
@erkexzcx I've added default colors |
|
I've tried it, looking good! |
|
Hey there. Thanks again for your PR. Currently I had a lot going on in my life and haven't got time for this project. On top of that, I no longer have roborock vacuum robot, but planning to get one in the future, so therefore your PR is the last one for now. Added disclaimer to README.md for now and will remove that disclaimer in the future when I get back to this project. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ICantBelieveItsNotValetudo is deprecated and it mentions your repo as successor.
I've noticed that there is no possibility to change colors. Since I've used this feature I think it would be cool to add to your project as well.