This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
client/js/shout.js: tag Notifications to reduce notification spam #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamboman
changed the title
|
Some reads for the curious:
@williamboman, this creates one "notification area" per channel (so N messages on 1 channel trigger 1 notification, but 1 message on N channels trigger N notifications). Is that what you were aiming at? If so, you get my 👍. |
|
@williamboman, I forgot to follow-up on this, sorry. This is a very simple fix but has some nice impact, so it would be great to have your comments on my question :-) I'm flagging this for second review as I believe this can be merged either way. |
Yep! Rebased on top of latest master. |
|
Perfect, thanks! Full 👍 :-) |
|
👍 |
erming
added a commit
that referenced
this pull request
Jan 24, 2016
client/js/shout.js: tag Notifications to reduce notification spam
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.