Badges badges badges #465
Badges badges badges #465
Conversation
|
Your |
|
Ah, well spotted! Adding one right now! |
|
You might want to change the name on the copyright to |
astorije
force-pushed
the
astorije/badges
branch
from
5188787
to
4d604e7
Compare
|
-__-' |
|
@JocelynDelalande, @erming, may I have your respective 👍 on this? |
| @@ -0,0 +1,21 @@ | |||
| The MIT License (MIT) | |||
|
|
|||
| Copyright (c) 2015 Mattias Erming | |||
There was a problem hiding this comment.
add « and contributors », since there is no CLA as far as I know.
There was a problem hiding this comment.
Oh boy, that moment at the end of a talk when you hope no one would raise their hands when you ask "Any questions?"
I don't know. This is a tricky question. At first I was like, sure why not, then after reading this, I'm like, heck, that's why not. Honestly, we do not want a CLA, that would just get in the way of enhancing that project (I know of one project I contribute to that requires to sign a CLA, and boy it's tedious for everyone).
This seems like we would need a keen eye on this. I'm sure she is very busy, but if @wseltzer happens to receive notifications, and would be okay to help us a bit, that would be great :-)
@wseltzer, essentially, this is an Free and Open Source Software project under the MIT license and we get a lot of contributions. What would be the best thing to type here? Of course it's always nice when we give the right credit to the right people, but on the other hand if that forces us to get agreement from all contributors if we decide to change license), that would be hard to organize.
@JocelynDelalande, what I am sure about though, is that I want this PR to make it into master quickly :-) Can I get your +1 and continue the discussion to reach to a solution even if it has to be done post-merged, in another PR?
There was a problem hiding this comment.
@JocelynDelalande, what I am sure about though, is that I want this PR to make it into master quickly :-) Can I get your +1 and continue the discussion to reach to a solution even if it has to be done post-merged, in another PR?
Sure :) so please reflect current project state : copyright holder is "Mathias Erming and contributors", I was not discussing if we wanted a CLA or not, that's outside the scope of this PR.
There was a problem hiding this comment.
Aaah yeah, sure, whatever, done in 92d2466.
astorije
force-pushed
the
astorije/badges
branch
from
4d604e7
to
92d2466
Compare
|
-1 for me. Sure, you can add the license if you want (even though I don't think it's needed). But I don't know about the badges. I just think they're ugly and unnecessary. |
|
@erming, badges are a nice display of seriousness accessible on a first glance. Let's follow well accepted/de facto open source conventions here please. Some world class examples:
Also, dude, it's SVG badges, how can you find them ugly! :D (PNG badge on the current README weeps my eyes on Retina ^^) |
|
Also, it adds transparency (if our project is broken, we don't hide it), which is always a good thing. |
|
+1 For badges, definitely a good addition. |
|
That's a 👍 for me also. @erming those badges are not a matter of being « flashy & shiny », (yes, visual aspect is debatable but it's bikeshedding IMHO). The matter is : it allows some visitor to evaluate quickly your project : is it active ? are dependencies up-to-date ? are tests passing ? I'm evaluating OSS projects on a daily basis, the information carried by badges is valuable as hints about software quality. It's not about having a badges collection, it's about being transparent on software quality. Another point in favor of those badges is: if they are turning red, it will give us a reminder to take action in order to get them green. |
|
@astorije is PR title in link with http://www.badgerbadgerbadger.com/ ? |
What else? ^^ Also thanks @JocelynDelalande for putting better words on my exact thoughts. Hope that @erming will change his mind :-) |
|
Ah, another pro-badges argument: I froze for a moment where trying to get to our Travis CI builds. "Wait, where do I click already? Right, I need to manually type the URL..." :-) |
|
👍 |
astorije
force-pushed
the
astorije/badges
branch
from
92d2466
to
bcb5d76
Compare
astorije
force-pushed
the
astorije/badges
branch
2 times, most recently
from
b028303
to
a67a77d
Compare
|
Rebased on master to comply with changes added by #508. |
|
Remove |
|
Whyyyyyy, please nooooo! What's wrong with clearly expressing what free license we are using and easily linking to it?! |
astorije
force-pushed
the
astorije/badges
branch
from
a67a77d
to
a5316ae
Compare
|
I live to fight another day. Removed, merging now. |
Pretty pretty badges, because red looks nicer in SVG!