Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Fix word wrap on firefox. #570

Merged
merged 1 commit into from
Jan 24, 2016
Merged

Fix word wrap on firefox. #570

merged 1 commit into from
Jan 24, 2016

Conversation

AlMcKinlay
Copy link
Contributor

Word wrap doesn't work on firefox if it is a continuous stream of characters without any spaces. Making it an inline block makes that work.

@AlMcKinlay AlMcKinlay changed the title Fix word wrap on firefox. Fixes #101 Fix word wrap on firefox. Jan 9, 2016
@astorije
Copy link
Collaborator

astorije commented Jan 9, 2016

Hey @YaManicKill, thanks for your contribution! Do you have some before/after screenshots to share on this please?

@astorije astorije added the bug label Jan 9, 2016
@astorije astorije self-assigned this Jan 9, 2016
@AlMcKinlay
Copy link
Contributor Author

I'll upload some in a bit.

@astorije
Copy link
Collaborator

astorije commented Jan 9, 2016

Thanks! I'll review afterwards :-)

@AlMcKinlay
Copy link
Contributor Author

Before the change:

screenshot from 2016-01-09 20-05-58

After the change:

screenshot from 2016-01-09 20-06-12

@dgw
Copy link

dgw commented Jan 9, 2016

❤️ inline-block. 👍

@astorije
Copy link
Collaborator

Nice catch, easy fix, you sir have my 👍
Awaiting for a second approval from the other maintainers and this can go.

Thanks!

@xPaw
Copy link
Contributor

xPaw commented Jan 23, 2016

👍

@astorije
Copy link
Collaborator

Thanks @YaManicKill!

astorije added a commit that referenced this pull request Jan 24, 2016
@astorije astorije merged commit b4bcf8f into erming:master Jan 24, 2016
@AlMcKinlay AlMcKinlay deleted the fix-word-wrap branch January 24, 2016 16:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants