This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
A couple of fixes for Morning and Zenburn themes #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes white background on `#main` which flashes while chat is loading - Removes 5px padding on the left of the whole window on mobile devices - Brings back Leave and Send buttons - Style buttons to be a darker style (leave, send, show more history)
| /* Hide unnecessary buttons */ | ||
| #windows .header .button, | ||
| #form #submit { | ||
| display: none; |
There was a problem hiding this comment.
Yeah, I agree with this. It's confusing if a user changes a theme and then can't leave any rooms on mobile. took me ages to figure out this is why there wasn't a leave button.
|
Hey @xPaw, could you post some before/after screenshots (and the small screen size equivalents when affected) for each of these please? :-) |
|
|
| #form #input { | ||
| background-color: #2e3642; | ||
| border-color: #242a33; | ||
| color: #cccccc; | ||
| padding-left: 1em !important; |
|
👍 Thanks! |
erming
added a commit
that referenced
this pull request
Jan 24, 2016
A couple of fixes for Morning and Zenburn themes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#mainwhich flashes while chat is loadingDespite what the author of morning theme thinks, it's important to keep UI elements (leave/send buttons).