New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Vorbis Mode Parsing #27

Merged

eshaz merged 5 commits into master from fix-vorbis-modes

Aug 7, 2023

Owner

eshaz commented Aug 7, 2023

Fixes

Allow for Vorbis mode count miss-match. See trouble with some oggs wasm-audio-decoders#86
Return 0 samples on first Vorbis frame per specification.

Data is not returned from the first frame; it must be used to ’prime’ the decode engine. The encoder accounts for this priming when calculating PCM offsets; after the first frame, the proper PCM output offset is ’0’ (as no data has been returned yet). [1]

eshaz added 5 commits

August 6, 2023 18:40


          fix: remove vorbis mode error check, correct samples decoded

294ffb7


          test: update callback assertions, add instance reuse tests

dc88077


          test: add granule position to tests

4a65b37


          chore: update deps

09f62e2


          chore: patch release

f78bbb7

eshaz merged commit 3ad0384 into master

eshaz deleted the fix-vorbis-modes branch

August 7, 2023 01:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet