Skip to content

Commit

Permalink
[BREAKING] base64::encode() compat with esp32: no newlines by default (
Browse files Browse the repository at this point in the history
  • Loading branch information
d-a-v committed Mar 15, 2021
1 parent 656a33e commit 4cc1472
Showing 1 changed file with 14 additions and 2 deletions.
16 changes: 14 additions & 2 deletions cores/esp8266/base64.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,23 @@ class base64
// NOTE: The default behaviour of backend (lib64)
// is to add a newline every 72 (encoded) characters output.
// This may 'break' longer uris and json variables
static String encode(const uint8_t * data, size_t length, bool doNewLines = true);
static String inline encode(const String& text, bool doNewLines = true)
static String encode(const uint8_t * data, size_t length, bool doNewLines);
static inline String encode(const String& text, bool doNewLines)
{
return encode( (const uint8_t *) text.c_str(), text.length(), doNewLines );
}

// esp32 compat:

static inline String encode(const uint8_t * data, size_t length)
{
return encode(data, length, false);
}

static inline String encode(const String& text)
{
return encode(text, false);
}
private:
};

Expand Down

0 comments on commit 4cc1472

Please sign in to comment.