LED_BUILTIN should be a #define #4276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,7 +33,7 @@ | |||
| static const uint8_t SDA = PIN_WIRE_SDA; | |||
| static const uint8_t SCL = PIN_WIRE_SCL; | |||
|
|
|||
| static const uint8_t LED_BUILTIN = 16; | |||
| static const uint8_t BUILTIN_LED = 16; | |||
| #define LED_BUILTIN 16 | |||
There was a problem hiding this comment.
Could a compiler #define such as "-DBUILTIN_LED=LED_BUILTIN" and remove the need for all these repeated 2nd #define BUILTIN_LED X?
There was a problem hiding this comment.
BUILTIN_LED is not used in core, but seems to be historically used in esp8266 code outside.
What about moving this define into variants/generic/common.h (hidden, wrong name less exposed, less loaded gcc cmdline) ?
There was a problem hiding this comment.
If it's not standard, how about putting it somewhere safe and deprecating its use?
devyte
requested changes
Feb 6, 2018
variants/espino/pins_arduino.h
Outdated
| static const uint8_t LED_BUILTIN_R = 2; | ||
| static const uint8_t LED_BUILTIN_G = 4; | ||
| static const uint8_t LED_BUILTIN_B = 5; | ||
|
|
||
| static const uint8_t BUILTIN_LED = 2; | ||
| /* |
variants/espino/pins_arduino.h
Outdated
| static const uint8_t LED_BUILTIN_R = 2; | ||
| static const uint8_t LED_BUILTIN_G = 4; | ||
| static const uint8_t LED_BUILTIN_B = 5; | ||
|
|
||
| static const uint8_t BUILTIN_LED = 2; | ||
| /* | ||
| static const uint8_t BUILTIN_LEDR = 2; | ||
| static const uint8_t BUILTIN_LEDG = 4; | ||
| static const uint8_t BUILTIN_LEDB = 5; | ||
| static const uint8_t BUILTIN_BUTTON = 0; |
There was a problem hiding this comment.
maybe there should be a BUTTON_BUILTIN?
There was a problem hiding this comment.
Right. BUTTON_BUILTIN added, commented BUILTIN_* removed.
deduplicate and hide BUILTIN_LED as a deprecated constant
devyte
approved these changes
Feb 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arduino only defines LED_BUILTIN, should BUILTIN_LED be removed ?