Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spiffs lseek typo for seek_end #4287

Merged
merged 2 commits into from
Feb 6, 2018
Merged

Fix spiffs lseek typo for seek_end #4287

merged 2 commits into from
Feb 6, 2018

Conversation

devyte
Copy link
Collaborator

@devyte devyte commented Feb 4, 2018 •
edited
Loading

Fixes #2597 .

This was referenced Feb 4, 2018
Closed
Closed
@devyte devyte self-assigned this Feb 4, 2018
d-a-v
d-a-v approved these changes Feb 5, 2018
View reviewed changes
Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the spiffs api the offset from END has to be negative. And I understand from doc/filesystem.rst that the offset from end is positive in our core-api.
Then that's OK.

@devyte devyte merged commit 9694b3e into esp8266:master Feb 6, 2018
@devyte devyte deleted the issue2597 branch February 7, 2018 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-a-v d-a-v d-a-v approved these changes

Assignees

@devyte devyte

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@devyte @d-a-v