Move cont_* funcs from ram to flash #4384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igrr
requested changes
Feb 19, 2018
cores/esp8266/cont_util.c
Outdated
| @@ -57,7 +57,7 @@ int ICACHE_RAM_ATTR cont_get_free_stack(cont_t* cont) { | |||
| return freeWords * 4; | |||
| } | |||
|
|
|||
| bool ICACHE_RAM_ATTR cont_can_yield(cont_t* cont) { | |||
| bool cont_can_yield(cont_t* cont) { | |||
There was a problem hiding this comment.
This can be called from ISR, when cache is disabled, so it's best to keep it in IRAM.
devyte
requested changes
Feb 19, 2018
cores/esp8266/cont_util.c
Outdated
| @@ -38,13 +38,13 @@ void ICACHE_RAM_ATTR cont_init(cont_t* cont) { | |||
| } | |||
| } | |||
|
|
|||
| int ICACHE_RAM_ATTR cont_check(cont_t* cont) { | |||
| int cont_check(cont_t* cont) { | |||
There was a problem hiding this comment.
I'm calling this from an ISR, so it needs to be in RAM.
My usage is as a kind of canary for stack usage. I suppose that would no longer be necessary when the breakpoint approach is implemented, but until then, I'd prefer this be kept in RAM.
cores/esp8266/cont_util.c
Outdated
| if(cont->stack_guard1 != CONT_STACKGUARD || cont->stack_guard2 != CONT_STACKGUARD) return 1; | ||
|
|
||
| return 0; | ||
| } | ||
|
|
||
| int ICACHE_RAM_ATTR cont_get_free_stack(cont_t* cont) { | ||
| int cont_get_free_stack(cont_t* cont) { |
There was a problem hiding this comment.
I intend to call this from an ISR for statistical purposes (on my todo list for my application), so I'd prefer to keep it in RAM.
kylefleming
force-pushed
the
move-cont-funcs-to-flash
branch
from
4d6ac3d
to
72696a6
Compare
devyte
approved these changes
Mar 23, 2018
|
@igrr I think this is ok now. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think these can go in flash and not take up ram space since the functions that call them are all also located in flash.