Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace old Ethernet Arduino-library with v2, submoduled #6812

Merged
merged 7 commits into from
Jul 16, 2020
Merged

replace old Ethernet Arduino-library with v2, submoduled #6812

merged 7 commits into from
Jul 16, 2020

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Nov 19, 2019 •
edited
Loading

supports W5500, W5200 and W5100

edit:
closes #2671
fixes #3943

@devyte
Copy link
Collaborator

devyte commented Nov 20, 2019

Fixes #3943

@devyte devyte added this to the 2.7.0 milestone Nov 20, 2019
@d-a-v
Copy link
Collaborator Author

d-a-v commented Dec 21, 2019

@Misiu
@mynameisbill2

Have you had success with this updated ethernet driver ?

@Misiu
Copy link

Misiu commented Dec 21, 2019

@d-a-v sadly I didn't have a chance to try this out. I'm still waiting for boards. It's my third order, previous didn't arrived. Hopefully this one will.

@d-a-v d-a-v modified the milestones: 2.7.0, 3.0.0 Jan 20, 2020
@mynameisbill2
Copy link

@d-a-v I have tested the d-a-v:arduinoethernet, it's OK, but the esp8266:master's code haven't been replaced. I don't familiar whith the Github, which time the d-a-v:arduinoethernet barnch can be mereged into the esp8266:master? I hope it more quickly!

@d-a-v
Copy link
Collaborator Author

d-a-v commented Apr 5, 2020

@mynameisbill2
Thanks for the report !
You can also try with #6680 which proposes more integrated drivers that will allow you to use any network library available with WiFi but with your ethernet adapter (mqtt/webserver/webclient/any other).
Both will be merged soon (or at least #6680) after release 2.7.0 of this core is out.

Also, alpha version 0.0.2 already contains this (#6812) pull request.

@d-a-v d-a-v mentioned this pull request May 20, 2020
Closed
6 tasks
earlephilhower
earlephilhower approved these changes Jul 16, 2020
View reviewed changes
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Unable to test, but moving us to the standard will help people for sure.

@d-a-v d-a-v merged commit dfd5a4f into esp8266:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

Assignees

@d-a-v d-a-v

Labels
component: libraries type: enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Please add support WizNet W5500 for Ethernet lib. Basic example for modified ethernet.h
5 participants
@d-a-v @devyte @Misiu @mynameisbill2 @earlephilhower