Make DNS resolution order selectable during runtime or compile time #6865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…only in dual stack mode).
d-a-v
reviewed
Dec 4, 2019
There was a problem hiding this comment.
The core API is respected and extended with lwIP-v2's IPv6 API, thanks !
This however has a lack of documentation.
There is currently no documentation on IPv6, but only one example.
Could you update the IPv6.ino example and show how the new argument can be used ?
…ectable resolving order
|
Sorry for the commit-chaos. Hat no dev-environment at hand. Now IPv6.ino has an example on how to use the extended hostByName(). |
devyte
requested changes
Dec 5, 2019
…only in dual stack mode).
…ectable resolving order
… enum class isn't used.
|
Ok, changed to using an enum class for DNS resolution type. Hope this is what you intended. |
d-a-v
approved these changes
Apr 4, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified ESP8266WifiGeneric to allow selection of DNS resolution order. Can be controlled by dns.h defines or in an extended api call Wifi.hostByName(const char* aHostname, IPAddress& aResult, uint32_t timeout_ms, uint8_t resolveType) in dual stack mode (LWIP_IPV4 and LWIP_IPV6 is set).