Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configTime(tzsec,dstsec,): fix UTC/local management #6993

Merged
merged 11 commits into from
Feb 18, 2020
Merged

configTime(tzsec,dstsec,): fix UTC/local management #6993

merged 11 commits into from
Feb 18, 2020

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Jan 6, 2020 •
edited
Loading

This PR also removes dead code since probably newlib updates.
The NTP-TZ-DST example is updated.

fixes #6921
fixes #6678

@d-a-v
configTime(tzsec,dstsec,): fix UTC/local management
11ff54f 
This PR also remove dead code since probably newlib updates
The NTP-TZ-DST example is also updated
@d-a-v d-a-v mentioned this pull request Jan 6, 2020
Closed
6 tasks
@d-a-v d-a-v added this to the 2.7.0 milestone Jan 6, 2020
@earlephilhower
Copy link
Collaborator

Any PR that drops 300+ lines of legacy, unmaintained code w/o dropping functionality is awesome!

earlephilhower
earlephilhower requested changes Jan 22, 2020
View reviewed changes
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little worried about the signed->unsigned on timezone_secs. Other stuff very minor. Looking good...

cores/esp8266/sntp-lwip2.cpp Outdated Show resolved Hide resolved
cores/esp8266/sntp-lwip2.cpp Outdated Show resolved Hide resolved
cores/esp8266/sntp-lwip2.cpp Outdated Show resolved Hide resolved
cores/esp8266/time.cpp Outdated Show resolved Hide resolved
cores/esp8266/time.cpp Show resolved Hide resolved
libraries/esp8266/examples/NTP-TZ-DST/NTP-TZ-DST.ino Outdated Show resolved Hide resolved
@d-a-v d-a-v mentioned this pull request Jan 24, 2020
Closed
6 tasks
@d-a-v d-a-v merged commit f066ed2 into esp8266:master Feb 18, 2020
@d-a-v d-a-v deleted the configTimeTZ branch February 18, 2020 15:39
@arendst
Copy link

arendst commented Feb 19, 2020 •
edited
Loading

For some reason after this was merged my sntp code stopped working.

Undefined references to the once documented SNTP API calls by espressif:

  • sntp_get_real_time
  • sntp_get_current_timestamp
  • sntp_set_timezone

I guess some functionality has been dropped...

@earlephilhower
Copy link
Collaborator

@arendst can you open a new issue on this? This is closed-merged, so anything here won't show up on our lists w/o explicitly looking for it.

@arendst arendst mentioned this pull request Feb 19, 2020
Closed
@arendst
Copy link

arendst commented Feb 19, 2020

Done.

@d-a-v d-a-v mentioned this pull request Jun 6, 2020
Open
6 tasks
@d-a-v d-a-v mentioned this pull request Jun 20, 2020
Closed
@glmnet glmnet mentioned this pull request Aug 30, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

@devyte devyte devyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7.0
4 participants
@d-a-v @earlephilhower @arendst @devyte