Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define MAX_SERVOS to 12, like original Servo.h #6999

Merged
merged 3 commits into from
Jan 9, 2020
Merged

Define MAX_SERVOS to 12, like original Servo.h #6999

merged 3 commits into from
Jan 9, 2020

Conversation

earlephilhower
Copy link
Collaborator

Fixes #6997

@earlephilhower earlephilhower added this to the 2.7.0 milestone Jan 8, 2020
@earlephilhower
Copy link
Collaborator Author

There has been internal discussion about changing this # at compile-time with some rules of thumb when using boards with limited IOs. That said, for now, we're going to go with this and see if it does become an issue.

@earlephilhower earlephilhower merged commit 677007f into esp8266:master Jan 9, 2020
@earlephilhower earlephilhower deleted the servitude branch January 9, 2020 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-a-v d-a-v d-a-v approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

Servo.h should define MAX_SERVOS
2 participants
@earlephilhower @d-a-v