Added input_netif to the stored data #7004
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LaborEtArs
commented
Jan 8, 2020
LaborEtArs
commented
- Added a 'setMulticastInterface' method for netifs.
- The input_netif is also only available, while 'inside' of the recv-callback. Added this to the temp-saved data.
- Found problems with omitted UDP messages, therefore disabled the the omitting of messages.
- Made '_pcb' accessible
d-a-v
reviewed
Jan 8, 2020
|
Reinserted the code that omits UDP messages |
d-a-v
reviewed
Jan 17, 2020
| void setMulticastInterface(netif* p_pNetIf) | ||
| { | ||
| #if LWIP_VERSION_MAJOR == 1 | ||
| udp_set_multicast_netif_addr(_pcb, (p_pNetIf ? ip_2_ip4(p_pNetIf->ip_addr) : ip_addr_any)); |
There was a problem hiding this comment.
ip_2_ip4() is useless with lwIP-1.4
Arduino/cores/esp8266/IPAddress.h
Line 33 in 00440cd
d-a-v
reviewed
Jan 17, 2020
| @@ -265,7 +290,6 @@ class UdpContext | |||
| // ref'ing it to prevent release from the below pbuf_free(deleteme) | |||
| pbuf_ref(_rx_buf); | |||
| } | |||
| // remove the already-consumed head of the chain | |||
There was a problem hiding this comment.
Perhaps it has to be replaced by
'remove parts of the pbuf chain that are not anymore "ref"ed'
|
There are unwanted submodule updates in this PR
(see #7003 (comment)) |
|
Can't remove these submodules. Every time I do checkout a new branch, these (and other) submodule are added automagically by git. Closing the PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.