Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unacceptable defaults that destroy servos #7023

Merged
merged 11 commits into from
Nov 14, 2020
Merged

Commits on Oct 31, 2020

  1. The default timings were chosen vastly outside specification. On COTS…

    … servos, this causes much confusion for the user, because a wide range of angle starting from 0 degress, and a just a large range of angle leading up to 180 degrees, is dead - in fact, the servo doesn't move at all, from any position.
    
    Not investigated further for obvious reasons, as this may have also destroyed servos that ran hot trying to abide by the PWM signal but could not mechanically!
    dok-net committed Oct 31, 2020
    Configuration menu
    Copy the full SHA
    0827917 View commit details
    Browse the repository at this point in the history
  2. Change timing limits to safe values. With previous default timings an…

    …d safety limits, popular servos
    
    could force against internal physical endstops, which could overload and destroy them.
    dok-net committed Oct 31, 2020
    Configuration menu
    Copy the full SHA
    a2a1e0d View commit details
    Browse the repository at this point in the history
  3. Review action: revert changes to hard boundary for min/max duty cycle…

    … timings. Internal review, fix/drop legacy comments.
    dok-net committed Oct 31, 2020
    Configuration menu
    Copy the full SHA
    86caa07 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cc26161 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e7695a9 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4c4906f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c551dc2 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ac0f239 View commit details
    Browse the repository at this point in the history
  9. Default microsecond lower bound of 1000 causes confusing behavior - 2…

    …00 is minimum enforced elsewhere, so use it here too as nearest multiple of 100 from 180.
    dok-net committed Oct 31, 2020
    Configuration menu
    Copy the full SHA
    ef33c5f View commit details
    Browse the repository at this point in the history
  10. Comment rationale for changed defaults of min/max pulse widths.

    Comment rationale for changed defaults of min/max pulse widths.
    dok-net committed Oct 31, 2020
    Configuration menu
    Copy the full SHA
    66933c1 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2020

  1. Configuration menu
    Copy the full SHA
    2f1e390 View commit details
    Browse the repository at this point in the history