Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose webserver's chunk api #7134

Merged
merged 5 commits into from
Apr 7, 2020
Merged

Expose webserver's chunk api #7134

merged 5 commits into from
Apr 7, 2020

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Mar 4, 2020

This API is already existing but not quite exposed nor used in examples.
It allows to dynamically build and send large webpages without needing to store everything in a single memory buffer (namely String with all bad implications).

FSBrowser example has been slightly modified.
As a consequence it does not support HTTP/1.0 anymore.

Copy link
Collaborator

@devyte devyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d-a-v
Copy link
Collaborator Author

d-a-v commented Apr 6, 2020

@mhightower83 This is going to be merged so #7182 can use it,
Last chance to comment about your 👀 - CI is working right now

@devyte devyte merged commit d600cc7 into esp8266:master Apr 7, 2020
@devyte devyte added this to the 2.7.0 milestone Apr 7, 2020
@mhightower83
Copy link
Contributor

@d-a-v This is great! The other day, I was looking for an API call to do this and didn't find it.

@d-a-v
Copy link
Collaborator Author

d-a-v commented Apr 7, 2020

I thank the original designer too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants