Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic authentication with ESP8266httpUpdate #7190

Merged
merged 7 commits into from
Jul 30, 2020
Merged

Basic authentication with ESP8266httpUpdate #7190

merged 7 commits into from
Jul 30, 2020

Conversation

drhideg
Copy link
Contributor

@drhideg drhideg commented Apr 4, 2020

Add ability to use basic access authentication with ESP8266httpUpdate

Add ability to use basic access authentication with ESP8266httpUpdate
Add ability to use basic access authentication with ESP8266httpUpdate
@drhideg
Copy link
Contributor Author

drhideg commented Apr 10, 2020

Possible soultion for issue #3812 where unable to use http.setAuthorization for ESPhttpUpdate.

@devyte
Copy link
Collaborator

devyte commented May 4, 2020

Also, is authorization the right term here? our webserver seems to use authentication for user/pass.

Edit: I see HTTPClient uses authorization, so I guess we keep that.

Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@earlephilhower earlephilhower added this to the 3.0.0 milestone Jul 18, 2020
@earlephilhower earlephilhower merged commit d92e1ed into esp8266:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants