Fix for MD5 leak bug, issue #7195 #7197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-a-v
approved these changes
Apr 7, 2020
|
@lrodorigo I wouldn't mind a unique_ptr solution at all, at the very least it would be one small step towards exception friendly code. |
|
@lrodorigo ping? will you be reworking this with a smart ptr? |
|
Sorry, I read quickly your message and I misunderstood your message. I can try to rework for a smart_ptr, no-except code. I can start to work on it after easter holidays. |
That will be nice ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
freebefore the return.I was wondering if a more "C++ish" resource handling could be fine for you (e.g. buffer as unique_ptr).
Fixes #7195