MD5 Builder: Rework for unqiue_ptr instead of malloc for internal dynamic buffers. #7208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devyte
approved these changes
Apr 11, 2020
|
Thanks, @lrodorigo ! |
|
@earlephilhower I'm so happy to cooperate with you, in this important project. If you think that I'm appropriate, please let me know if I can cooperate with you in a more stable way and what I can do now. Regards |
|
@lrodorigo if you would like to help move the core forward, please msg me in our gitter channel gitter.im/esp8266/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to guarantee exception-safety I used
unique_ptrtouint8_t[], withstd::nothrowdecorator.I cannot mark the functions as no-except because I don't know if the called functions (especially the Stream implementations) are no-except.
I also fixed the const-correctness of const member functions, such as toString() and getters.
I executed the host tests, I still need to run tests on the ESP8266, but this is the first time that I contribute with you, so I have to study how to setup and run your tests suite on my device.