Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph example #7299

Merged
merged 12 commits into from
Jun 3, 2020
Merged

Graph example #7299

merged 12 commits into from
Jun 3, 2020

Conversation

vdeconinck
Copy link
Contributor

Hello. As promised during refactoring of FSBrowser in #7182 , I created a new stand-alone Graph application, demonstrating the periodic HTTP call to the ESP to get GPIO, analog and heap values and display them as charts.
The result looks like this:
image
@devyte: Many many thanks for the help. I'll be glad to get your feedback on the code.

@devyte devyte self-requested a review May 12, 2020 01:51
@devyte devyte self-assigned this May 12, 2020
@devyte devyte added this to the 2.7.2 milestone May 12, 2020
@earlephilhower
Copy link
Collaborator

Very cool looking. One thing I'm noting on FF latest is that the lower 2 graphs (analogRead/freeHeap) have negative values on the Y axis, and should really go from 0....n

image

Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool example! Very pretty and I can see it being useful to people.

Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice example which would be quite useful !

Copy link
Collaborator

@devyte devyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two very minor things. Other than that, congratulations, this looks really good.

libraries/ESP8266WebServer/examples/Graph/Graph.ino Outdated Show resolved Hide resolved
libraries/ESP8266WebServer/examples/Graph/Graph.ino Outdated Show resolved Hide resolved
libraries/ESP8266WebServer/examples/Graph/Graph.ino Outdated Show resolved Hide resolved
@devyte devyte merged commit c3796a4 into esp8266:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants