Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configTime: keep-up with old usage #7357

Closed
wants to merge 2 commits into from
Closed

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Jun 7, 2020

fixes #7353

@d-a-v
Copy link
Collaborator Author

d-a-v commented Jun 7, 2020

@Jason2866 I wonder if this PR breaks binary size again

@d-a-v
Copy link
Collaborator Author

d-a-v commented Jun 8, 2020

Closing: This PR breaks #7109 .

With #7357 and a sketch calling configTime(123,456,"abc"):

IROM   : 347868          - code in flash         (default or ICACHE_FLASH_ATTR) 
IRAM   : 27340   / 32768 - code in IRAM          (ICACHE_RAM_ATTR, ISRs...) 
DATA   : 1224  )         - initialized variables (global, static) in RAM/HEAP 
RODATA : 1712  ) / 81920 - constants             (global, static) in RAM/HEAP 
BSS    : 25048 )         - zeroed variables      (global, static) in RAM/HEAP 
Sketch uses 378144 bytes (36%) of program storage space. Maximum is 1044464 bytes.
Global variables use 27984 bytes (34%) of dynamic memory, leaving 53936 bytes for local variables.

Without:

IROM   : 339532          - code in flash         (default or ICACHE_FLASH_ATTR) 
IRAM   : 27268   / 32768 - code in IRAM          (ICACHE_RAM_ATTR, ISRs...) 
DATA   : 1224  )         - initialized variables (global, static) in RAM/HEAP 
RODATA : 1608  ) / 81920 - constants             (global, static) in RAM/HEAP 
BSS    : 24984 )         - zeroed variables      (global, static) in RAM/HEAP 
Sketch uses 369632 bytes (35%) of program storage space. Maximum is 1044464 bytes.
Global variables use 27816 bytes (33%) of dynamic memory, leaving 54104 bytes for local variables. ```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting timezone with setenv doesn't work properly any more with V 2.7.1
1 participant