Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libraries/SPI: abs -> std::abs and cast fixes #7362

Merged
merged 6 commits into from
Jun 13, 2020

Commits on Jun 8, 2020

  1. libraries/SPI: remove pointless abs(...) call

    SPI library code erroneously assumed that:
    - abs() is a C function, so include stdlib.h is required.
      what happens instead is Arduino.h shadows `abs()` with it's own macro
    - uint32_t() - int32_t() promotes to int32_t, thus needing abs()
    
    Fix both issues, leaving existing calculations as-is.
    mcspr committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    436bbc6 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2020

  1. additional changes for freq and constants

    - restore abs call, cast freq to correctly display the intent
    - update magic numbers comments
    - move some spiclk_t magic numbers to func consts
    mcspr committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    cb8ed2a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5f31800 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2020

  1. Configuration menu
    Copy the full SHA
    a2b7aa0 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2020

  1. Configuration menu
    Copy the full SHA
    6af0436 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2020

  1. Configuration menu
    Copy the full SHA
    ece351f View commit details
    Browse the repository at this point in the history