httpclient: fix error meaning #7401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earlephilhower
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed HTTPClient error name and log from "Refused" to "Failed" (both macro and string).
"refused" can lead to false assumptions.
"refused" macro is kept for backward compatibility. This is not a breaking change.
update:
A TCP-"connection refused" is an answer from peer telling that there is nothing listening on this tcp port (when a firewall is in the way, the error becomes a timeout error).
But this httpclient error can be returned even when the question cannot be asked because it can be caused by a local error (wifi not connected for example).
For the correct distinction between a local error and a real "connection refused", WiFiClient API has to be updated with an additional function returning the last real error (returned by lwIP (refused, unreachable, ...) or by local hardware (abort, ...)).