sys/pgmspace.h: Refactor inline asm #7510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor asm tabs for `.S` cosmetics * Avoid fixed regname (`a14`) allocation * Remove unnecessary explicit cast and word masking
|
Howdy, @jjsuwa! Looks good if a bit pedantic (dropping casts). Let me do a couple checks on real HW just to verify the In the meantime, this file comes from upstream in the newlib toolchain. Can you put in the same PR there? https://github.com/earlephilhower/newlib-xtensa OTW, this change will be lost as soon as a new toolchain build is done. |
earlephilhower
approved these changes
Aug 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor asm tabs for
.ScosmeticsAvoid fixed regname (
a14) allocationRemove unnecessary explicit cast and word masking