Fix long password validation in WebServer #7676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a base64 encode that doesn't add CRs to the output when comparing username:password values for authentication. Fixes esp8266#7664
earlephilhower
added
component: web
hacktoberfest-accepted
|
Testing... |
|
Verified. Works as expected. Thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a base64 encode that doesn't add CRs to the output when comparing
username:password values for authentication.
Fixes #7664
@arendst, can you please give this patch a try? I've tested a 100 character password with the HTTPBasicAuth example and it works for me.