Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to pyserial 3.5, esptool 3.0 #7737

Merged
merged 3 commits into from
Dec 2, 2020
Merged

Update to pyserial 3.5, esptool 3.0 #7737

merged 3 commits into from
Dec 2, 2020

Conversation

earlephilhower
Copy link
Collaborator

Recent releases may work better with some newer MacOS releases
according to their commit logs.

@earlephilhower
Update to pyserial 3.5, esptool 3.0
2978492 
Recent releases may work better with some newer MacOS releases
according to their commit logs.
@d-a-v
Copy link
Collaborator

d-a-v commented Dec 1, 2020 •
edited
Loading

esptool has a breaking change:

The default esptool.py write_flash --flash_size argument has changed from detect to keep. This means that if no --flash_size argument is passed when flashing a bootloader, the value in the bootloader .bin file header is kept instead of detecting the actual flash size and updating the header. To keep the old behaviour, add the argument esptool.py [...] write_flash [...] -fs detect

Should we keep on with (old) default behavior ?

@earlephilhower
Add backward compatible flash size detection
6f8dd8c 
Ensure esptool detects the flash size and doesn't use the one hardcoded
in the bootloader.  Thanks to @d-a-v for noticing the esptool change.
@earlephilhower
Copy link
Collaborator Author

Good catch, @d-a-v! Updated to pass in the detect option automatically.

...
Changing baud rate to 460800
Changed.
Configuring flash size...
Auto-detected Flash size: 4MB
Compressed 318240 bytes to 230844...
...

d-a-v
d-a-v approved these changes Dec 2, 2020
View reviewed changes
Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and better flashing logs in the arduino console !
Thanks for having fixed esptool too :)

@earlephilhower earlephilhower merged commit 8565ac8 into esp8266:master Dec 2, 2020
@earlephilhower earlephilhower deleted the pysernew branch December 2, 2020 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-a-v d-a-v d-a-v approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@earlephilhower @d-a-v