Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor EspSoftwareSerial release 6.11.0 #7802

Merged
merged 2 commits into from
Dec 31, 2020
Merged

Minor EspSoftwareSerial release 6.11.0 #7802

merged 2 commits into from
Dec 31, 2020

Conversation

dok-net
Copy link
Contributor

@dok-net dok-net commented Dec 31, 2020

More GPIOs for ESP32

@earlephilhower
Copy link
Collaborator

@dok-net looks like some warning issues in headers. Please check the CI logs:

/home/runner/arduino_ide/hardware/esp8266com/esp8266/libraries/SoftwareSerial/src/SoftwareSerial.cpp: In member function 'bool SoftwareSerial::hasRxGPIOPullUp(int8_t)':
/home/runner/arduino_ide/hardware/esp8266com/esp8266/libraries/SoftwareSerial/src/SoftwareSerial.cpp:76:45: error: unused parameter 'pin' [-Werror=unused-parameter]
   76 | bool SoftwareSerial::hasRxGPIOPullUp(int8_t pin) {
      |                                      ~~~~~~~^~~
cc1plus: all warnings being treated as errors

@earlephilhower earlephilhower merged commit 229903a into esp8266:master Dec 31, 2020
dok-net added a commit to dok-net/arduino-esp8266 that referenced this pull request Dec 31, 2020
@dok-net
Revert "Minor EspSoftwareSerial release 6.11.0 (esp8266#7802)"
a1d2424 
This reverts commit 229903a.
@dok-net dok-net mentioned this pull request Dec 31, 2020
Merged
@dok-net
Copy link
Contributor Author

dok-net commented Dec 31, 2020

PR #7804 fixes this. Overlapping work on merge and still WIP EspSoftwareSerial PR branch updates (library release tags...) with force push caused a malconfiguration.

earlephilhower pushed a commit that referenced this pull request Dec 31, 2020
@dok-net
Minor EspSoftwareSerial release 6.11.1 (#7804)
a25895a 
* Minor EspSoftwareSerial release 6.11.0: more GPIOs for ESP32

* EspSoftwareSerial: Fix unused parameter warning.

* Revert "Minor EspSoftwareSerial release 6.11.0 (#7802)"

This reverts commit 229903a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dok-net @earlephilhower