Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String: add missing long long operator implementations #7888

Merged
merged 2 commits into from
Feb 19, 2021

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Feb 19, 2021

fixes #7885

Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Looking at this now, it seems like StringSumHelper is screaming for a template...

@earlephilhower earlephilhower merged commit a5308d6 into esp8266:master Feb 19, 2021
@d-a-v d-a-v deleted the missingStringLL branch February 19, 2021 18:07
@d-a-v
Copy link
Collaborator Author

d-a-v commented Feb 19, 2021

Looking at this now, it seems like StringSumHelper is screaming for a template...

I told the same to myself and I remembered that we have pending #7781 which would remove all of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing operator +() implementation after : String: compatibility with 64 bits scalars (#7863)
2 participants