Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link to ESP8266 NonOS SDK #7914

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Fix link to ESP8266 NonOS SDK #7914

merged 1 commit into from
Mar 11, 2021

Conversation

ksalwin
Copy link
Contributor

@ksalwin ksalwin commented Mar 10, 2021

Topic under this link does not exist.
Link should point to ESP8266 SDK repository on GitHub.

@d-a-v
Copy link
Collaborator

d-a-v commented Mar 10, 2021

Thanks!
The correct link is https://github.com/espressif/ESP8266_NONOS_SDK/tree/release/v2.2.x

@ksalwin ksalwin closed this Mar 10, 2021
@ksalwin ksalwin reopened this Mar 10, 2021
@ksalwin
Copy link
Contributor Author

ksalwin commented Mar 11, 2021

Thank you for response.
Though I'd suggest to keep link generic enough not to be concerned by changes of SDK in the future.
Specific version of SDK is already in SDK version file. The approach of link to root not to label i've found also in README.md.

d-a-v
d-a-v approved these changes Mar 11, 2021
View reviewed changes
Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope it is soon that next change will be for a link pointing to RTOS-SDK :)

@earlephilhower earlephilhower merged commit e07542d into esp8266:master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-a-v d-a-v d-a-v approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ksalwin @d-a-v @earlephilhower