Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code-spell spelling checks to CI #8067

Merged
merged 10 commits into from
May 23, 2021

Conversation

earlephilhower
Copy link
Collaborator

Help find and fix silly spelling errors as they are added to the repo.

Help find and fix silly spelling errors as they are added to the repo.
Need to manually exclude certain files because code-spell interprets
things like PEM keys as words and not line noise.
Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After updating 132 files 👀, checks have passed !

@dok-net
Copy link
Contributor

dok-net commented May 22, 2021

Nice, sources look a lot more professional in an instant. Now if merging were an exact science, I could sleep calmly, but as it stands, and I've seen it happen, git and/or subsequent 3-way-merge editors have produced artifacts at times. And given the sheer number of files this PR touches, it's more likely something goes astray for already pending PRs once this were to get merged into master.
I have rebased all my PRs for testing purposes and there are at least two such merge conflicts that might take an extra amount of diligence to review in fine detail.

@earlephilhower earlephilhower merged commit 60fe7b4 into esp8266:master May 23, 2021
@earlephilhower earlephilhower deleted the speaknspell branch May 23, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants