BREAKING - "i2s.h" removed, I2S library added #8108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An "i2S.h" header was presesnt in prior cores, but this conflicts with the Arduino standard I2S.h header for the I2S class under Windows (because of case insensitivity). Initial 3.0.0 release has a redirect "i2s.h" file in the cores directory to redirect to the "I2S.h" file in the library, but under Windows this resulted in the IDE not building the I2S library and link errors. Remove the offending header. Code will need to mode to including "I2S.h" instead (which will include both the Arduino class as well as the low-level definitions). Fixes esp8266#8107
|
@earlephilhower Mind the include guards:
Unique, alright, but not quite the canonical / expected form :-) |
d-a-v
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An "i2S.h" header was presesnt in prior cores, but this conflicts with the
Arduino standard I2S.h header for the I2S class under Windows (because of
case insensitivity).
Initial 3.0.0 release has a redirect "i2s.h" file in the cores directory to
redirect to the "I2S.h" file in the library, but under Windows this resulted
in the IDE not building the I2S library and link errors.
Remove the offending header. Code will need to mode to including "I2S.h"
instead (which will include both the Arduino class as well as the low-level
definitions).
Fixes #8107