Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wire buffer length improvments. #8398

Merged
merged 2 commits into from
Dec 14, 2021
Merged

Wire buffer length improvments. #8398

merged 2 commits into from
Dec 14, 2021

Commits on Dec 7, 2021

  1. Enable I2C_BUFFER_LENGTH definition for Wire lib 

    Based on
paclema/arduino-esp32@375a89e

We should have been very careful when #defining things to not use a name
that could conflict with the user's own code, so this marks that old
define as deprecated.

If you opt-into the new behavior, you do not get the old BUFFER_LENGTH
constant.

As a bonus, changing these uint8_ts to size_t both reduces the code
size & improves performance.
    @flaviut
    flaviut committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    e7660b0 View commit details
    Browse the repository at this point in the history

  2. Increase buffer indexing variable size 

    I looked over the users of these variables and they should be fine with
no additional changes. The existing methods already have an option to
use size_t rather than uint8_t.

There's a few methods which return int instead of size_t, which isn't
great from a portability perspective but will be fine since this only is
designed to run on the ESP8266.
    @flaviut
    flaviut committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    733eef3 View commit details
    Browse the repository at this point in the history