Astyle to clang format #8464
Merged
Astyle to clang format #8464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
would a different author help filtering when blame / log-search is happening? |
|
Indeed FWIW and given the huge umber of changes, in the past and in my previous attempt I used the separate "allman" account in order to get a better commit history. |
|
Here's a relevant issue to watch: community/community#5033 |
mcspr
force-pushed
the
astyle-to-clang-format
branch
from
b1451b2
to
cfc9779
Compare
mcspr
force-pushed
the
astyle-to-clang-format
branch
from
cfc9779
to
7a3a9c4
Compare
Ignore mass-reformatting commits Include the clang-format, and the previous astyle Based on the idea from black https://black.readthedocs.io/en/stable/guides/introducing_black_to_your_project.html#avoiding-ruining-git-blame To be used with git CLI when exploring some specific file history ``` $ git blame --ignore-revs-file .git-blame-ignore-revs -- file.cpp ``` Or, by modifying the config to apply globally ``` $ git config blame.ignoreRevsFile .git-blame-ignore-revs ``` (note that the by default config will apply only for the current repository)
mcspr
force-pushed
the
astyle-to-clang-format
branch
from
7a3a9c4
to
9019c28
Compare
mcspr
added a commit
that referenced
this pull request
Mar 3, 2022
mcspr
added a commit
to mcspr/esp8266-Arduino
that referenced
this pull request
Mar 30, 2022
GitHub PR rebase-merge of esp8266#8464 introduced a new commit, instead of using the one from the PR tree. Point to that new one in the `master` branch. (fixing 24c4152 changes)
mcspr
added a commit
that referenced
this pull request
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces / amends #8455
there does not seem to be an option for one-line brace addition for if() { ... } while() { ... } etc. :/
clang-tidy might help with that, but it needs a build command line info via compile_commands.json so it can handle macros, build options, know the language context etc. For target build of the Core, arduino-cli or platformio can already do that, but need some kind of project file and there might be problems with dependencies not being picked up. Host files need something else, either manually create the .json or use some makefile generator like cmake to build mock files and retrieve build cmd that way.