Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix File::readString to work with binary data #8742

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Fix File::readString to work with binary data #8742

merged 1 commit into from
Dec 6, 2022

Commits on Dec 6, 2022

  1. Fix File::readString to work with binary data 

    Previously, File::readString used a C-style string as an intermediate
buffer via the String += operator. This treats a NUL byte as a
terminator, making this function work incorrectly if the File contains
binary data.

This commit switches the function to use String::concat, which doesn't
treat NUL bytes any differently (and is a bit faster, because it doesn't
need to use strlen).
    @elipsitz
    elipsitz committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    bd67b18 View commit details
    Browse the repository at this point in the history