Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiFi.setSleep with ENUM instead of boolean #3896

Closed
LasseRosenow opened this issue Apr 11, 2020 · 2 comments
Closed

WiFi.setSleep with ENUM instead of boolean #3896

LasseRosenow opened this issue Apr 11, 2020 · 2 comments
Labels
Status: Stale Issue is stale stage (outdated/stuck)

Comments

@LasseRosenow
Copy link

LasseRosenow commented Apr 11, 2020

I think its bad, that the WiFi.setSleep requires a boolen which will put it into WIFI_PS_MIN_MODEM or WIFI_PS_NONE but never into WIFI_PS_MAX_MODEM...

So if you want to put your device into WIFI_PS_MAX_MODEM sleep you have to use the low_level funcitons.

Why not just use the wifi_ps_type_t as the argument of WiFi.setSleep?
Example: setSleep(wifi_ps_type_t mode)

Or at least give us the possibility to specify the wifi_ps_type_t with the second parameter if you don't want to break things.
Example: setSleep(bool enable, wifi_ps_type_t mode)

@stale
Copy link

stale bot commented Jun 10, 2020

[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Stale Issue is stale stage (outdated/stuck) label Jun 10, 2020
@stale
Copy link

stale bot commented Jun 25, 2020

[STALE_DEL] This stale issue has been automatically closed. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Stale Issue is stale stage (outdated/stuck)
Projects
None yet
Development

No branches or pull requests

1 participant