Remove dateOfFirstVisit and dateOfMostRecentVisit and update example data #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These dates are not used by Akita and there are no plans to use this information, so we should not store it. Signed-off-by: sharon-wang <[email protected]>
Signed-off-by: sharon-wang <[email protected]>
vezwork
approved these changes
Jan 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dateOfFirstVisitanddateOfMostRecentVisitare not used by Akita and there are no plans to use this information, so we should not store it. Also there was something broken with the date calculation anyways (showing something like2020-undefined-01).We could also get rid of
AkitaOriginVisitDataand store the visit data directly in theAkitaOriginData, opened #109 for this. Getting rid of it now (right before Chrome store submission) would be a risky change, so deferring it to later.Also updated our example data so the numbers make more sense and to fix some typos.