clientv3/integration: finish isolated node test cases #8785
Conversation
| func TestBalancerUnderNetworkPartitionSerializableGet(t *testing.T) { | ||
| testBalancerUnderNetworkPartition(t, func(cli *clientv3.Client, ctx context.Context) error { | ||
| _, err := cli.Get(ctx, "a", clientv3.WithSerializable()) | ||
| if err == context.DeadlineExceeded { |
There was a problem hiding this comment.
for s-get, it should return immediately since it does not need go through raft. we should not even see deadline exceed, right?
There was a problem hiding this comment.
Removed and only kept s-get case that expects always succeeds on the first try.
| }, 2*time.Second, false) | ||
| } | ||
|
|
||
| func TestBalancerUnderNetworkPartitionSerializableGetRetry(t *testing.T) { |
There was a problem hiding this comment.
what is the difference between Get and GetRetry?
There was a problem hiding this comment.
LinearizableGetWithRetry expects quorum get succeeds on the second try, after network partition happens.
LinearizableGetWithNoRetry expects quorum get blocks until balancer switch after network partition. Otherwise error out (without manual retry--expects first request succeeds).
1. one with retry 2. one without retry (range request with longer timeouts) Signed-off-by: Gyu-Ho Lee <[email protected]>
|
lgtm if tests pass. |
Codecov Report
@@ Coverage Diff @@
## master #8785 +/- ##
=========================================
Coverage ? 76.09%
=========================================
Files ? 360
Lines ? 29648
Branches ? 0
=========================================
Hits ? 22560
Misses ? 5516
Partials ? 1572Continue to review full report at Codecov.
|
#8711