-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP: On-Chain EIP-712 Visualization #6865
Conversation
…n-eip feat: add initial EIP proposal
✅ All reviewers have approved. |
…n-eip fix: the first match of the given pattern must be a link
…n-eip feat: fix linting errors
…n-eip fix: spacing linting
The commit ab2fc30 (as a parent of 7bccab5) contains errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey @SamWilsn, is there anything pending? if not can we merge this draft please or there are some procedures to go through? Thanks for the feedbacks! |
Co-authored-by: Sam Wilson <[email protected]>
formatting and Capitalization of Type Co-authored-by: Sam Wilson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: