Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: On-Chain EIP-712 Visualization #6865

Merged
merged 22 commits into from
May 20, 2023
Merged

Conversation

a6-dou
Copy link
Contributor

@a6-dou a6-dou commented Apr 11, 2023

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@a6-dou a6-dou requested a review from eth-bot as a code owner April 11, 2023 10:33
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc labels Apr 11, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Apr 11, 2023

✅ All reviewers have approved.

@eth-bot eth-bot changed the title EIP-712 Visualization Website: EIP-712 Visualization Apr 11, 2023
@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Apr 11, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Apr 11, 2023
@eth-bot eth-bot changed the title Website: EIP-712 Visualization Add EIP: on-chain EIP-712 Visualization Apr 11, 2023
@eth-bot eth-bot added the e-review Waiting on editor to review label Apr 11, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Apr 11, 2023
@github-actions
Copy link

The commit ab2fc30 (as a parent of 7bccab5) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Apr 11, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Apr 11, 2023
EIPS/eip-6865.md Outdated Show resolved Hide resolved
@a6-dou a6-dou requested a review from lightclient April 14, 2023 20:57
Copy link

@cynic-1 cynic-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

EIPS/eip-6865.md Outdated Show resolved Hide resolved
EIPS/eip-6865.md Outdated Show resolved Hide resolved
EIPS/eip-6865.md Outdated Show resolved Hide resolved
EIPS/eip-6865.md Outdated Show resolved Hide resolved
EIPS/eip-6865.md Outdated Show resolved Hide resolved
EIPS/eip-6865.md Outdated Show resolved Hide resolved
EIPS/eip-6865.md Outdated Show resolved Hide resolved
@eth-bot eth-bot changed the title Add EIP: on-chain EIP-712 Visualization Add EIP: On-chain EIP-712 Visualization May 3, 2023
@eth-bot eth-bot changed the title Add EIP: On-chain EIP-712 Visualization Add EIP: On-Chain EIP-712 Visualization May 3, 2023
@a6-dou a6-dou requested a review from SamWilsn May 3, 2023 08:54
@a6-dou
Copy link
Contributor Author

a6-dou commented May 10, 2023

Hey @SamWilsn, is there anything pending? if not can we merge this draft please or there are some procedures to go through?

Thanks for the feedbacks!

EIPS/eip-6865.md Outdated Show resolved Hide resolved
EIPS/eip-6865.md Outdated Show resolved Hide resolved
EIPS/eip-6865.md Outdated Show resolved Hide resolved
EIPS/eip-6865.md Show resolved Hide resolved
EIPS/eip-6865.md Show resolved Hide resolved
@a6-dou a6-dou requested a review from SamWilsn May 18, 2023 08:17
@eth-bot eth-bot enabled auto-merge (squash) May 20, 2023 05:47
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants