Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

params: default to shanghai evm version on local dev nets #27360

Closed
wants to merge 3 commits into from

Conversation

q9f
Copy link
Contributor

@q9f q9f commented May 26, 2023

Running a local geth --dev environment still defaults to the London-EVM version, whereas most tooling (e.g., Solidity) expects Shanghai by default.

I'm not sure what the long-term plan is with the local devnet, but I found it quite handy to run tests against a local EVM, and now I need Shanghai. 💛

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, curious to see if the tests pass with the change in TestChainConfig

@q9f q9f marked this pull request as draft May 26, 2023 12:15
@q9f
Copy link
Contributor Author

q9f commented May 26, 2023

Ok, the idea was good, but the consequences are massive 😆

  • I removed Shanghai from the TestChainConfig to avoid opening the can of worms tests I would have to review
  • While tinkering with the consensus rules for Clique and Ethash, I realized that it's suboptimal to add features that expect a merged network to a consensus engine that implies no beacon consensus.
  • My intermediate conclusion is that we can not and eventually should not add Shanghai to these engines.

This leaves us with the option to either create a custom Shanghai (without EIP 4895) for testing or, better, create a fake beacon-chain consensus for the local devnet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants