This repository has been archived by the owner on Jun 13, 2020. It is now read-only.
Removed chef helpers from ganglia_graph.rb to remove chef dependancy #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndancy. Requiring chef to check if chef is installed doesn't make sense.
|
Unfortunately, I don't think this solution works well because we do require Chef to look up the Ganglia cluster name. I'll modify this helper to be smarter about requiring Chef support and fall back to a simpler mechanism to look up the cluster name. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commented out chef helpers as per kargig's suggestion in #19
Nothing else in the code base seems to make use of them at the moment, and this seems to have solved the chef dependancy issue.
Let me know if this seems to break anything on your end.