Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix panic when optional chain partially replaced with defines #3554

Merged
merged 5 commits into from
Dec 18, 2023

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Dec 18, 2023

Closes #3551

Hi, I just started to explore code base for this opportunity to investigate the issue further. Probably this change is not the most appropriate fix, but for the sake of showing what I found so far, I'm making this draft PR first.

I would appreciate if you could provide any guidance on more principled fix (Or if you have a plan to fix in a different PR, then I'm happy to close this PR as well).

Btw, I love esbuild. Thanks a lot for making this awesome tool!

@hi-ogawa hi-ogawa marked this pull request as ready for review December 18, 2023 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when transforming optional chaining with define
2 participants