fix: remove --debug flag for browserify. #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the spec (https://goo.gl/UQJKOW) the source map comment should be at the very end of the file. Browser's adhere to that, i.e. use the last source map in the file. Browserify's --debug adds a source map at the bottom of the compiled file, but currently fails to combine that with the source map referenced in script.js. This is a bug in Browserify, see issue browserify/browserify#772. Our test case thus only worked by accident, for the user in the browser only "script.js" shows up, not "script.coffee" as it should. So for the time being, we should just remove the --debug flag from the build and re-enable once browserify fixes that issue.
|
This unblocks issue #60. |
|
Hmm, interesting. I don't use browserify myself so I wasn't aware of this. I'd rather leave the test broken so that we can tell when the issue is fixed. Removing the --debug flag also doesn't seem like a good idea since it sounds like it's an unsupported workflow and won't work if more than one source file uses a source map. The flag is only used in generating browserify-test and shouldn't affect the module itself. |
Merged
This was referenced Sep 25, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the spec (https://goo.gl/UQJKOW) the source map comment should be
at the very end of the file. Browser's adhere to that, i.e. use the last source
map in the file.
Browserify's --debug adds a source map at the bottom of the compiled file, but
currently fails to combine that with the source map referenced in script.js.
This is a bug in Browserify, see issue
browserify/browserify#772.
Our test case thus only worked by accident, for the user in the browser only
"script.js" shows up, not "script.coffee" as it should.
So for the time being, we should just remove the --debug flag from the build and
re-enable once browserify fixes that issue.