-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix backend to recalculate start time on match update #587
base: master
Are you sure you want to change the base?
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @evroon on Vercel. @evroon first needs to authorize it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #587 +/- ##
==========================================
- Coverage 90.40% 90.25% -0.15%
==========================================
Files 123 124 +1
Lines 3938 4002 +64
==========================================
+ Hits 3560 3612 +52
- Misses 378 390 +12 ☔ View full report in Codecov by Sentry. |
Made draft as I need to make some test cases first tbh |
This PR is stale because it has been open for 45 days with no activity. Remove the |
Yes github bot I'm aware, also being away from the machine with all the necessary changes is hard too |
This PR is stale because it has been open for 45 days with no activity. Remove the |
Got round to testing, not sure why this shouldn't work |
Well, I should say that it's been working in production for us for a long while, I haven't tested on a local machine but I'm pretty sure it's been working very reliably for long. Shall I attempt to add a test for this @evroon ? |
If you could add a test, that would be nice indeed! |
"100% of diff hit" according to CodeCov, so there you have it 👍 |
This PR is stale because it has been open for 45 days with no activity. Remove the |
@evroon ? |
No description provided.