Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backend to recalculate start time on match update #587

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

robigan
Copy link
Contributor

@robigan robigan commented Mar 6, 2024

No description provided.

Copy link

vercel bot commented Mar 6, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @evroon on Vercel.

@evroon first needs to authorize it.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.25%. Comparing base (0f1cde5) to head (7293010).
Report is 193 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #587      +/-   ##
==========================================
- Coverage   90.40%   90.25%   -0.15%     
==========================================
  Files         123      124       +1     
  Lines        3938     4002      +64     
==========================================
+ Hits         3560     3612      +52     
- Misses        378      390      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robigan robigan marked this pull request as draft March 6, 2024 13:53
@robigan
Copy link
Contributor Author

robigan commented Mar 6, 2024

Made draft as I need to make some test cases first tbh

Copy link
Contributor

github-actions bot commented May 5, 2024

This PR is stale because it has been open for 45 days with no activity. Remove the stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label May 5, 2024
@robigan
Copy link
Contributor Author

robigan commented May 29, 2024

Yes github bot I'm aware, also being away from the machine with all the necessary changes is hard too

@github-actions github-actions bot removed the Stale label May 30, 2024
Copy link
Contributor

This PR is stale because it has been open for 45 days with no activity. Remove the stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Jun 30, 2024
@robigan robigan changed the title Fix backend to recalculate start time on match update [Updated] Fix backend to recalculate start time on match update Jul 10, 2024
@robigan robigan marked this pull request as ready for review July 10, 2024 10:34
@robigan
Copy link
Contributor Author

robigan commented Jul 10, 2024

Got round to testing, not sure why this shouldn't work

@robigan
Copy link
Contributor Author

robigan commented Jul 10, 2024

Well, I should say that it's been working in production for us for a long while, I haven't tested on a local machine but I'm pretty sure it's been working very reliably for long. Shall I attempt to add a test for this @evroon ?
image

@evroon
Copy link
Owner

evroon commented Jul 10, 2024

If you could add a test, that would be nice indeed!

@github-actions github-actions bot removed the Stale label Jul 12, 2024
@robigan
Copy link
Contributor Author

robigan commented Jul 15, 2024

If you could add a test, that would be nice indeed!

"100% of diff hit" according to CodeCov, so there you have it 👍

Copy link
Contributor

This PR is stale because it has been open for 45 days with no activity. Remove the stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added Stale and removed Stale labels Aug 16, 2024
@robigan
Copy link
Contributor Author

robigan commented Aug 19, 2024

@evroon ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants