-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rank by points #749
base: master
Are you sure you want to change the base?
Rank by points #749
Conversation
@IzStriker is attempting to deploy a commit to the evroon's projects Team on Vercel. A member of the Team first needs to authorize it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #749 +/- ##
==========================================
+ Coverage 92.72% 92.77% +0.04%
==========================================
Files 108 108
Lines 3727 3749 +22
==========================================
+ Hits 3456 3478 +22
Misses 271 271 ☔ View full report in Codecov by Sentry. |
Thanks for the PR, I hope to be able to look at it within a few days |
Hmm I looked at it but I am not sure this is the way to go. I would prefer something more flexible, like how other tournament systems have a scoring system. There you can kind of "design" your scoring, and specify how much So what I think we want is a table of scorings, and each row in that table contains settings as to how the scoring works. So how many points are awarded per win and per tie for example. Most tournaments will just use one kind of scoring. Later we can extend this system to also take into account scoring for forfeits, "bye"s, scoring of sets within matches etc. It also lets you define tie-breaking criteria, but that can wait for another time. There's also two things that are currently a bit of a mistake in my implementation:
Sorry I didn't come up with this earlier. What do you think of this approach? |
I think understand what you're suggesting. However, I implemented the scoring system in this PR because it's the system my local club uses to score tournaments. I don't think I could achieve the same system with what you're describing unless I am misunderstanding and this would have to exist along side your suggestion to be able to rank by points. Let me know if I'm missing something. |
I'm working on a draft here: #797 Ah I think I understand now what you mean why it wouldn't work. It's because you add the number of points in the match as ranking, not the result of the match (win or loss). I should be able to implement that in my PR. If you want to write code, I can also skip that part (but make it easy to implement) and let you do that. |
I'm not fused about writing code, but let me know if you want help with anything. Also, if you don't need this PR feel free to close it. 🙂 |
This PR is stale because it has been open for 45 days with no activity. Remove the |
Partially addresses #524
When choosing teams from a previous stage, teams can now either be ranked by the highest elo or the highest amount of points accumulated across matches.