This repository has been archived by the owner on Feb 15, 2019. It is now read-only.
Make NavigationBar.Title more extendable #421
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Split NavigationBar.Title’s container and text up into separate components - Container handles platform padding, alignment, etc… - Text handles platform title text styles - Using the components directly applications are free to insert things before/after, wrap the text in a touch handler, replace the text with a non-text element, use multiple title text elements, or do any other type of title bar customization. - Used `justifyContent` on `title` instead of `flex`+`textAlign` on `titleText` for centering. This makes the container responsible for alignment and works in more situations than `textAlign` (non-text, multiple components, etc… all work). And also rids the text component from non-text related layout styles and frees it to be used multiple times or in other placements.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
justifyContentontitleinstead offlex+textAlignontitleTextfor centering. This makes the container responsible for alignment and works in more situations thantextAlign(non-text, multiple components, etc… all work). And also rids the text component from non-text related layout styles and frees it to be used multiple times or in other placements.