Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add theme colors for diff and patch files #21

Merged
merged 5 commits into from
Aug 14, 2023

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Aug 14, 2023

Fixes #20

  • Added example.patch based on this file
  • Added dark & light color themes based on GitHub coloring
Dark Light
Dark diff Light diff

Note, added background colors as part of the tmLanguage file, but it's not yet supported in vscode.

@byCedric byCedric requested a review from Simek August 14, 2023 15:54
Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👌 We might consider altering the modified lines background in the future, as we do in docs, but this is definitely not a blocker:
Screenshot 2023-08-14 at 18 01 51

This is not (yet) supported by vscode, but once it does, it has the same colors as our docs.

See: microsoft/vscode#3429
@byCedric
Copy link
Member Author

Added the background colors, but see microsoft/vscode#3429

@byCedric byCedric merged commit 62a7d90 into main Aug 14, 2023
1 check passed
@byCedric byCedric deleted the @bycedric/diff/add-theme-colors branch August 14, 2023 16:21
expo-bot added a commit that referenced this pull request Aug 14, 2023
## [1.2.0](1.1.0...1.2.0) (2023-08-14)

### New features

* add theme colors for diff and patch files ([#21](#21)) ([62a7d90](62a7d90))
@expo-bot
Copy link
Contributor

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support diff files
3 participants