Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

fix(azure)!: Changes the values return type from Azure Key vault Prev… #460

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

Flydiverny
Copy link
Member

@Flydiverny Flydiverny commented Jul 31, 2020

This is a breaking change for azure key vault users

fix(azure)!: Changes the values return type from Azure Key vault Previously secret value was wrapped in an object { "value": } while now will be returned directly so KES features can be properly used (migration: "property: value" -> remove property selector)

Allows storing JSON in azure vault backend and extracting fields etc!

eg

Secret values in azure keyvault:

password=lolsogood
credentials={"username":"wtf","password":"lol","host":"greenland"}

apiVersion: 'kubernetes-client.io/v1'
kind: ExternalSecret
metadata:
  name: hello-service-azure
spec:
  backendType: azureKeyVault
  keyVaultName: kes-test
  data:
    - key: password
      name: password
    - key: credentials
      name: username
      property: username

->

apiVersion: v1
kind: Secret
metadata:
  name: hello-service-azure
  namespace: default
type: Opaque
data:
  password: bG9sc29nb29k
  username: d3Rm

and (removing property selector for credentials)

apiVersion: 'kubernetes-client.io/v1'
kind: ExternalSecret
metadata:
  name: hello-service-azure
spec:
  backendType: azureKeyVault
  keyVaultName: kes-test
  data:
    - key: password
      name: password
    - key: credentials
      name: username

->

apiVersion: v1
kind: Secret
metadata:
  name: hello-service-azure
  namespace: default
type: Opaque
data:
  password: bG9sc29nb29k
  username: eyJ1c2VybmFtZSI6Ind0ZiIsInBhc3N3b3JkIjoibG9sIiwiaG9zdCI6ImdyZWVubGFuZCJ9

Currently you have to do:

apiVersion: 'kubernetes-client.io/v1'
kind: ExternalSecret
metadata:
  name: hello-service-azure
spec:
  backendType: azureKeyVault
  keyVaultName: kes-test
  data:
    - key: password
      name: password
      property: value
    - key: credentials
      name: username
      property: value

which limits KES usability.

…iously secret value was wrapped in an object { "value": <secret> } while now <secret> will be returned directly so KES features can be properly used (migration: "property: value" -> remove property selector)
@Flydiverny Flydiverny merged commit 36d5bbb into external-secrets:master Sep 29, 2020
@Flydiverny Flydiverny deleted the azure-fix branch September 29, 2020 00:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants