Update .gitmodules repo protocol (to support general public use) #262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
correct your marlin fork repo URL to use https+git instead, so that folks who don't have privileges on that repo (ie, the general public) can still install this plugin via pip.
This came up when trying to recover my installation after an OS upgrade replaced my python interpreter with a new version, causing me to have to "rebuild" site-packages.
While doing so, I got a
pip freeze
output of the original site-packages which included:OctoPrint-PrintTimeGenius @ git+https://github.com/eyal0/OctoPrint-PrintTimeGenius.git@70081671a24628aa23d9da28ff58b7b9ec8fa104
This fails out with the following:
This is easily mitigated by using the https URLs for submodules. If you do not have an ssh key added to a user with appropriate permissions, you cannot use the
git@
scheme. This affects pretty much anyone except for you, as your user owns that fork?