Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitmodules repo protocol (to support general public use) #262

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Update .gitmodules repo protocol (to support general public use) #262

merged 1 commit into from
Aug 6, 2021

Conversation

draeath
Copy link
Contributor

@draeath draeath commented Aug 6, 2021

correct your marlin fork repo URL to use https+git instead, so that folks who don't have privileges on that repo (ie, the general public) can still install this plugin via pip.

This came up when trying to recover my installation after an OS upgrade replaced my python interpreter with a new version, causing me to have to "rebuild" site-packages.

While doing so, I got a pip freeze output of the original site-packages which included:
OctoPrint-PrintTimeGenius @ git+https://github.com/eyal0/OctoPrint-PrintTimeGenius.git@70081671a24628aa23d9da28ff58b7b9ec8fa104

This fails out with the following:

Collecting OctoPrint-PrintTimeGenius@ git+https://github.com/eyal0/OctoPrint-PrintTimeGenius.git@70081671a24628aa23d9da28ff58b7b9ec8fa104
  Cloning https://github.com/eyal0/OctoPrint-PrintTimeGenius.git (to revision 70081671a24628aa23d9da28ff58b7b9ec8fa104) to ./pip-install-l7qr49d1/octoprint-printtimegenius_caa61677980a42b2b4f4efcc75219277
  Running command git clone -q https://github.com/eyal0/OctoPrint-PrintTimeGenius.git /tmp/pip-install-l7qr49d1/octoprint-printtimegenius_caa61677980a42b2b4f4efcc75219277
  Running command git rev-parse -q --verify 'sha^70081671a24628aa23d9da28ff58b7b9ec8fa104'
  Running command git fetch -q https://github.com/eyal0/OctoPrint-PrintTimeGenius.git 70081671a24628aa23d9da28ff58b7b9ec8fa104
  Running command git checkout -q 70081671a24628aa23d9da28ff58b7b9ec8fa104
  Resolved https://github.com/eyal0/OctoPrint-PrintTimeGenius.git to commit 70081671a24628aa23d9da28ff58b7b9ec8fa104
  Running command git submodule update --init --recursive -q
  [email protected]: Permission denied (publickey).
  fatal: Could not read from remote repository.

  Please make sure you have the correct access rights
  and the repository exists.
  fatal: clone of '[email protected]:eyal0/Marlin.git' into submodule path '/tmp/pip-install-l7qr49d1/octoprint-printtimegenius_caa61677980a42b2b4f4efcc75219277/submodules/Marlin' failed
  Failed to clone 'submodules/Marlin'. Retry scheduled
  [email protected]: Permission denied (publickey).
  fatal: Could not read from remote repository.

  Please make sure you have the correct access rights
  and the repository exists.
  fatal: clone of '[email protected]:eyal0/Marlin.git' into submodule path '/tmp/pip-install-l7qr49d1/octoprint-printtimegenius_caa61677980a42b2b4f4efcc75219277/submodules/Marlin' failed
  Failed to clone 'submodules/Marlin' a second time, aborting
WARNING: Discarding git+https://github.com/eyal0/OctoPrint-PrintTimeGenius.git@70081671a24628aa23d9da28ff58b7b9ec8fa104. Command errored out with exit status 1: git submodule update --init --recursive -q Check the logs for full command output.

This is easily mitigated by using the https URLs for submodules. If you do not have an ssh key added to a user with appropriate permissions, you cannot use the git@ scheme. This affects pretty much anyone except for you, as your user owns that fork?

correct marlin repo URL to use https repo, so that folks who don't have privileges on that repo (ie, the general public) can still install this plugin via pip.
@draeath draeath changed the title Update .gitmodules Update .gitmodules repo protocol (to support general public use) Aug 6, 2021
@draeath
Copy link
Contributor Author

draeath commented Aug 6, 2021

Note I personally was able to figure out I had 2.2.7 and worked around this by just installing the release zip as per usual.

Just figured you might want to tweak this anyway? If you reject this PR it certainly won't hurt my feelings.

@eyal0 eyal0 merged commit 130afbc into eyal0:master Aug 6, 2021
@eyal0
Copy link
Owner

eyal0 commented Aug 6, 2021

No rejecting anything, I'm glad to have the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants