regexp update to extract filament len & vol from pS gcode. And fix python version handling #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now determines the python version right.
I'm using python 3.11 which newer than python 3.3.
But comparing the two numbers as float would deliver a wrong result.
Now major and minor version numbers are compared separately as int.
this fixes the following error messages:
————
2023-04-23 14:08:56,953 Running: "/home/ender/OctoPrint/venv/bin/python3" "/home/ender/OctoPrint/venv/lib/python3.11/site-packages/octoprint_PrintTimeGenius/analyzers/analyze_gcode_comments.py" "/home/ender/.octoprint/uploads/20230423-140640_1h54m_11,5g3,9m_0.4Nzl0.16PLA_235C55C0.968EF-0.08Z20%IrFR_20%IOL0.85BF_Form-Kubus_LA0.3_Speed10-70.gcode" --parsers slic3r_pe_print_time slic3r_pe_print_time_remaining
2023-04-23 14:09:02,535 Failed to run '"/home/ender/OctoPrint/venv/bin/python3" "/home/ender/OctoPrint/venv/lib/python3.11/site-packages/octoprint_PrintTimeGenius/analyzers/analyze_gcode_comments.py" "/home/ender/.octoprint/uploads/20230423-140640_1h54m_11,5g3,9m_0.4Nzl0.16PLA_235C55C0.968EF-0.08Z20%IrFR_20%IOL0.85BF_Form-Kubus_LA0.3_Speed10-70.gcode" --parsers slic3r_pe_print_time slic3r_pe_print_time_remaining'
Traceback (most recent call last):
File "/home/ender/OctoPrint/venv/lib/python3.11/site-packages/octoprint_PrintTimeGenius/__init__.py", line 348, in _do_analysis
raise Exception(results_err)
Exception: Traceback (most recent call last):
File "/home/ender/OctoPrint/venv/lib/python3.11/site-packages/octoprint_PrintTimeGenius/analyzers/analyze_gcode_comments.py", line 10, in <module>
from collections import Mapping as collections_Mapping
ImportError: cannot import name 'Mapping' from 'collections' (/usr/lib/python3.11/collections/__init__.py)
————
I'm using prusa slicer 2.5.2 for slicing. it writes the filament usage in .gcode files like this: ———— ; filament used [mm] = 3851.15 ; filament used [cm3] = 9.26 ; filament used [g] = 11.49 ; filament cost = 0.23 ; total filament used [g] = 11.49 ; total filament cost = 0.23 ———— I extended the regexp in the "process_slic3r_filament" parser to match filament usage & volume. They are extracted to match group 3 & 4.
eyal0
requested changes
May 26, 2023
HTXF-g
added a commit
to HTXF-g/example-files-etc...
that referenced
this pull request
May 26, 2023
HTXF-g
added a commit
to HTXF-g/example-files-etc...
that referenced
this pull request
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.